refs #9880 show index and bound in lots of `index out of bounds` errors #9881

timotheecour · 2018-12-07T00:35:50Z

there are still a few cases left; these can be done in future PR's

cooldome · 2018-12-07T21:44:46Z

+1 for the idea.
PR also needs more tests, not all changes made to codegen are covered by the tests.

timotheecour · 2018-12-09T02:37:31Z

PTAL
I added more test cases; we can always improve coverage in future PR's (let's not let perfect be the enemy of good)

Araq · 2018-12-09T08:29:45Z

Well for a start, the tests are red. tests/misc/tinvalidarrayaccess.nim is now red.

…ds` errors

timotheecour · 2018-12-10T02:29:26Z

/cc @Araq green now

timotheecour force-pushed the pr_ref_9880 branch from db5321e to 12bdb21 Compare December 7, 2018 00:36

timotheecour force-pushed the pr_ref_9880 branch from 12bdb21 to d2984c4 Compare December 9, 2018 02:36

timotheecour requested a review from Araq December 9, 2018 02:37

refs nim-lang#9880 show index and bound in lots of `index out of boun…

f3ecc15

…ds` errors

timotheecour force-pushed the pr_ref_9880 branch from d2984c4 to f3ecc15 Compare December 10, 2018 00:50

Araq merged commit bb1ce39 into nim-lang:devel Dec 11, 2018

timotheecour deleted the pr_ref_9880 branch December 11, 2018 21:45

Provide feedback